Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example to add ESOL dataset #2

Closed
thegodone opened this issue Mar 17, 2021 · 1 comment
Closed

Example to add ESOL dataset #2

thegodone opened this issue Mar 17, 2021 · 1 comment

Comments

@thegodone
Copy link

You give an interesting code and example, but I don't see how to use it with esol dataset.

I have seen that you combine pos and atom label in your data.x. but how do you build your edge_index ?

is it a local bonded index like in classical graphs or for full molecule indexes ?

Also does the Hs are needed for other target than QM9 ?

@zetayue
Copy link
Owner

zetayue commented Mar 30, 2021

I have seen that you combine pos and atom label in your data.x. but how do you build your edge_index ?
is it a local bonded index like in classical graphs or for full molecule indexes ?

We represent each molecular graph as a multiplex graph including (1) the global layer that captures global interactions and (2) the local layer that captures local interactions. Thus our model needs two edge_index information, edge_index_g and edge_index_l:

Also does the Hs are needed for other target than QM9 ?

We think this depends on the task being investigated as well as the computational resources. Besides, if the 3D molecular structures are not precise enough, including Hs might not be a good idea.

@zetayue zetayue closed this as completed Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants