Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compresor doesn't change file name ending after compression to different format #76

Closed
GediminasZukas opened this issue Aug 9, 2017 · 3 comments

Comments

@GediminasZukas
Copy link

I am using 2.1.0 version.

Let's say I want to compress JPEG image and save it as a PNG after compression.

The problem is that newly created PNG file name persists the same with .jpg ending after such compression.

To avoid this, I have to do something like this:

.compressToFileAsFlowable(file, file.getName().replace(".jpg", ".png"))

which is not good in my opinion and such thing should be handled by library.

@GediminasZukas GediminasZukas changed the title Compresor doesn't change file ending after compression to different format Compresor doesn't change name file ending after compression to different format Aug 10, 2017
@GediminasZukas GediminasZukas changed the title Compresor doesn't change name file ending after compression to different format Compresor doesn't change file name ending after compression to different format Aug 10, 2017
@Duna
Copy link

Duna commented Oct 15, 2017

ok, but if compression is webp then filename remains jpeg or png. Is it ok?
in builder a methid is welcome: .changeExtensionTo("webp")

@maher640
Copy link

maher640 commented Nov 8, 2017

I have the same problem. compression type is webp by they're saved as their original type!

@zetbaitsu
Copy link
Owner

Fixed on v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants