Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent problematic use of event types #1422

Open
2 tasks
richardolsson opened this issue Jun 3, 2023 · 0 comments
Open
2 tasks

Prevent problematic use of event types #1422

richardolsson opened this issue Jun 3, 2023 · 0 comments
Labels
🐬 Medium Just a nice sized issue. 🎨 needs-design ❓ needs-info Issue needs further information or decisions before proceeding 🛑 potentially blocked Potentially blocked by prerequisites (double check or ask someone, as it may have changed)

Comments

@richardolsson
Copy link
Member

Description

We want users to use "event types" when creating events, because it's an important aspect of the Zetkin model of being able to find people who participated in certain "types" of events down the line.

I propose that we solve this by adding a confirmation dialog when publish an event if it does not have a type, and another confirmation dialog when creating a new type, to encourage users not to create too many.

Relevant Job Stories

  • When I have a lot of events in my campaign, I want to be able to filter them based on type, so that I can easily distinguish things like handing out flyers, from events like meetings
  • When I’m creating a new event, I don’t want to forget adding a type, so that later when I use Smart Search or some other indirectly related feature I will find the people who attended the event
  • When I’m looking for people based on previous activity, I want to exclude everyone who attended a “Member meeting” type event, so that I can focus my search on activists and not meeting attendees

Estimated size (S, M, L)

I think this is a medium sized issue because it requires both some new functionality and some design consideration. But it's not very big, because we can reuse the confirm dialog from other places.

Prerequisites

None

Requirements

  • When user clicks "publish" on an event without a type, show a confirmation dialog explaining that not having a type makes it harder to search for participants in the future, and that they can add a type later.
  • When user tries to create a new event type, show a confirmation dialog explaining that it's a good idea to reuse types, and only create new ones when there is not already another one that fits

Possible implementations

Use the ZUIConfirmDialogContext.

Design specifications

None

Open questions

Is this even a good idea? Let's discuss!

@richardolsson richardolsson added 🎨 needs-design 🐬 Medium Just a nice sized issue. ❓ needs-info Issue needs further information or decisions before proceeding 🛑 potentially blocked Potentially blocked by prerequisites (double check or ask someone, as it may have changed) labels Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐬 Medium Just a nice sized issue. 🎨 needs-design ❓ needs-info Issue needs further information or decisions before proceeding 🛑 potentially blocked Potentially blocked by prerequisites (double check or ask someone, as it may have changed)
Projects
None yet
Development

No branches or pull requests

1 participant