Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align toktx usage with the latest release #266

Closed
arpu opened this issue Apr 7, 2021 · 2 comments
Closed

Align toktx usage with the latest release #266

arpu opened this issue Apr 7, 2021 · 2 comments

Comments

@arpu
Copy link

arpu commented Apr 7, 2021

found on gltf-transform git
donmccurdy/glTF-Transform#215

@zeux
Copy link
Owner

zeux commented Apr 12, 2021

I believe assign_primaries is mostly a technicality wrt the output image format descriptor (DFD) - unsure this would be very interesting to support - but target_type is indeed a great suggestion, as it allows higher quality decoding when using UASTC for single/dual channel textures. I will leave this open for a while though since this is only applicable for newest toktx release, and using these options with an older release would fail, so this requires version detection (which is cumbersome) or to simply wait for an official toktx release so that the command line interface stabilizes.

@zeux
Copy link
Owner

zeux commented May 22, 2021

It looks like neither three.js nor Babylon.js actually implement target_type based selection either, so right now this change wouldn't actually change anything wrt quality or resulting size in practice. Because of versioning challenges I'm going to close this for now - we will come back to this when renderers start actually using this information, but I'd expect this to take a while and I'm trying to keep the issues that are open to things that definitely need doing.

@zeux zeux closed this as completed May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants