Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zend_Db_Adapter_Pdo_Pgsql is broken with Postgres 12 #28

Closed
Megatherium opened this issue Oct 7, 2020 · 3 comments · Fixed by #29
Closed

Zend_Db_Adapter_Pdo_Pgsql is broken with Postgres 12 #28

Megatherium opened this issue Oct 7, 2020 · 3 comments · Fixed by #29

Comments

@Megatherium
Copy link

Megatherium commented Oct 7, 2020

adsrc has been considered 'historical' since PG8 and has finally been removed with PG12. The line can easily be replaced with pg_get_expr(d.adbin, d.adrelid) AS default_value, I have tested this down to PG9.6 but from reading the documentation this should work even with <8.0

Will this suffce?

@glensc
Copy link
Contributor

glensc commented Oct 7, 2020

If what you're saying, that the new proposed version works for PG < 8.0 and PG >= 8.0, I see no reason why not to make the proposed change.

@glensc
Copy link
Contributor

glensc commented Oct 7, 2020

Solved the same way in Shardj/zf1-future (#25):

so perhaps just cherry-pick the change.

@glensc
Copy link
Contributor

glensc commented Oct 7, 2020

there: #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants