This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Allow describing file upload fields #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new toggle for marking a field as a file upload. If true, it sets the `type` for the input field to `Zend\\InputFilter\\FileInput`, ensuring it can be validated correctly within the input filter chain. If a field returned by the API is a `FileInput`, ensures that the UI will display it as a file upload.
|
Complements zfcampus/zf-content-validation#14 -- which makes it actually possible for validation to properly validate uploads. |
weierophinney
added a commit
that referenced
this pull request
May 28, 2014
weierophinney
added a commit
that referenced
this pull request
May 28, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we allow specifying both filters and validators related to file uploads. However, file uploads need to be of a different
Zend\InputFilter\Inputtype in order to be validated correctly:FileInput. This patch allows toggling a value indicating whether or not the field is an upload file; if so, the UI will send atypefor the given field with a value ofZend\InputFilter\FileInput. Additionally, any fields returned by the API with that type will display with that flag toggled on.