This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Remove kobj and vnode interfaces (WIP) #497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the obj interface. This required slightly extending the spl_file_* interface.
The ksid_lookupdomain() and lookupdomain_rele() function rely on kmem_zalloc() and kmem_free(). This header must include sys/kmem.h. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
This was referenced Nov 11, 2015
Closed
|
@behlendorf The changes you propose would require that I rewrite openzfs/zfs#3907 to use Linux APIs at a time when I am preparing a refresh and have actually pushed it into production because the illumos developers prefer to receive patches with production code. This would make porting patches back and forth much more difficult. I would rather get the libzfs_core extensions finalized and sent to illumos before doing any major refactoring here. |
|
Closing as stale. I'll refresh this and open a new PR when I can. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only for review and feedback. Removes the kobj, vnode, and spl_file, interfaces from the SPL. A simplified implementation will be added to the ZFS source tree. This existing code has served it's purpose well but it's needlessly complicated. With minor changes on the ZFS side it can be vastly simplified.