This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Fix build on kernel 4.13 onwards #654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building SPL within the kernel tree, C99 initializers cause build failures and need to be converted to C89 as kernel CFLAGS specify -std=gnu89. This fix was provided by @behlendorf in openzfs#595 discussion notes and manually implemented in the current master revision. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: RageLtMan <rageltman@sempervictus> Closes openzfs#597
|
@fahadsadah thanks for identifying and porting this fix. However, since we do not plan on tagging any new 0.6.5.x releases, and the fix is already in the 0.7.x series, I'm going to close this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build fails on kernels 4.13 onwards, which enable struct randomisation (torvalds/linux@3859a27) invalidating positional struct accesses
The spl-proc.c file has a couple of positional struct accesses, removed in v0.7. This PR cherry-picks commit 120faef into the spl-0.6.5-release branch to remove them here too and fix the build :)