Skip to content

Commit

Permalink
Remove superfluous statement
Browse files Browse the repository at this point in the history
Clang's static analyzer reported that the value assigned to pcksum is
never used. That is because we initialize both zc and pcksum to {{ 0 }}
and then do `pcksum = zc;`. That is fairly pointless. However, it has
the effect of generating a false positive in Clang's static analyzer.
Since noise from false positives can obscure real issues, we fix it
anyway.

Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Ned Bass <bass6@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #2330
  • Loading branch information
ryao authored and behlendorf committed May 31, 2014
1 parent 4def05f commit 2024041
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion cmd/zstreamdump/zstreamdump.c
Expand Up @@ -127,7 +127,6 @@ main(int argc, char *argv[])
}

send_stream = stdin;
pcksum = zc;
while (ssread(drr, sizeof (dmu_replay_record_t), &zc)) {

if (first) {
Expand Down

0 comments on commit 2024041

Please sign in to comment.