Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3 and pep8 support for arcstat and dbuffstat #1838

Closed
wants to merge 2 commits into from
Closed

python3 and pep8 support for arcstat and dbuffstat #1838

wants to merge 2 commits into from

Conversation

prometheanfire
Copy link
Contributor

I tested it a bit as well. Looks good to me :D

@prometheanfire
Copy link
Contributor Author

I could only go back to python 2.6 support though. I checked my modifications and I think 2.5 is good as well. Dunno how far back you guys go.

Tested 2.6 2.7 and 3.2

@behlendorf
Copy link
Contributor

@prometheanfire I'm fine with these changes and glad to see someone familiar with python taking an interest is cleaning this up. However, I can't merge this until you run down the error observed in dbufstat.py. When you fix that error please rebase this branch against master and squash the related committed together. I'm OK with either one big patch for these style fixes or if you prefer break them up by type. Just force push the new branch to github to update the pull request.

@prometheanfire
Copy link
Contributor Author

ya, been trying to get an ubuntu 12.04 server up with the daily ppa, but can't create a pool :(

zpool create asdasd /dev/disk/by-partuuid/afa9d030-5d49-4e13-8e9b-5adb8ff993d2
cannot create 'asdasd': invalid argument for this pool operation

gonna try centos next

@prometheanfire
pep8 code readability changes
e0bfffc 
making the code easier to deal with

Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>
@prometheanfire
python 3 fixes
90d70c1 
future proofing

Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>
@behlendorf
Copy link
Contributor

@prometheanfire Much better, thank you I'll merge it shortly.

behlendorf pushed a commit that referenced this pull request Nov 8, 2013
@prometheanfire @behlendorf
pep8 code readability changes
23bc1f9 
Update the code to follow the pep8 style guide.

References:
  http://www.python.org/dev/peps/pep-0008/

Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #1838
behlendorf pushed a commit that referenced this pull request Nov 8, 2013
@prometheanfire @behlendorf
Python 3 fixes
09d672d 
Future proofing for compatibility with newer versions of Python.

Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #1838
@behlendorf
Copy link
Contributor

Merged as:

09d672d Python 3 fixes
23bc1f9 pep8 code readability changes

@behlendorf behlendorf closed this Nov 8, 2013
ryao pushed a commit to ryao/zfs that referenced this pull request Nov 21, 2013
@prometheanfire @ryao
Python 3 fixes
75f4503 
Future proofing for compatibility with newer versions of Python.

Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#1838

Conflicts:
	cmd/dbufstat/dbufstat.py
unya pushed a commit to unya/zfs that referenced this pull request Dec 13, 2013
@prometheanfire @unya
pep8 code readability changes
086226a 
Update the code to follow the pep8 style guide.

References:
  http://www.python.org/dev/peps/pep-0008/

Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#1838
unya pushed a commit to unya/zfs that referenced this pull request Dec 13, 2013
@prometheanfire @unya
Python 3 fixes
8eba9f0 
Future proofing for compatibility with newer versions of Python.

Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#1838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prometheanfire @behlendorf