Illumos #4950 files sometimes can't be removed from a full filesystem #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryao
force-pushed
the
illumos-4950
branch
5 times, most recently
from
3a7a298
to
8be2e1f
Compare
Closed
…esystem Reviewed by: Adam Leventhal <adam.leventhal@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Sebastien Roy <sebastien.roy@delphix.com> Reviewed by: Boris Protopopov <bprotopopov@hotmail.com> Approved by: Dan McDonald <danmcd@omniti.com> Ported-by: Richard Yao <richard.yao@clusterhq.com> Porting notes: 1. ZoL currently does not log discards to zvols, so the portion of this patch that modifies the discard logging to mark it as freeing space has been discarded. 2. may_delete_now had been removed from zfs_remove() in ZoL. It has been reintroduced. 3. We do not try to emulate vnodes, so the following lines are not valid on Linux: mutex_enter(&vp->v_lock); may_delete_now = vp->v_count == 1 && !vn_has_cached_data(vp); mutex_exit(&vp->v_lock); This has been replaced with: mutex_enter(&zp->z_lock); may_delete_now = atomic_read(&ip->i_count) == 1 && !(zp->z_is_mapped); mutex_exit(&zp->z_lock);
kernelOfTruth
pushed a commit
to kernelOfTruth/zfs
that referenced
this pull request
Dec 13, 2014
…esystem openzfs#2784 Reviewed by: Adam Leventhal adam.leventhal@delphix.com Reviewed by: George Wilson george.wilson@delphix.com Reviewed by: Sebastien Roy sebastien.roy@delphix.com Reviewed by: Boris Protopopov bprotopopov@hotmail.com Approved by: Dan McDonald danmcd@omniti.com Ported-by: Richard Yao richard.yao@clusterhq.com Porting notes: 1. ZoL currently does not log discards to zvols, so the portion of this patch that modifies the discard logging to mark it as freeing space has been discarded. may_delete_now had been removed from zfs_remove() in ZoL. It has been reintroduced.
evansus
referenced
this pull request
in openzfsonosx/zfs
Dec 23, 2014
marks the transaction as a net free, helpful if the pool is low on free space
kernelOfTruth
pushed a commit
to kernelOfTruth/zfs
that referenced
this pull request
Feb 14, 2015
…esystem openzfs#2784 Reviewed by: Adam Leventhal adam.leventhal@delphix.com Reviewed by: George Wilson george.wilson@delphix.com Reviewed by: Sebastien Roy sebastien.roy@delphix.com Reviewed by: Boris Protopopov bprotopopov@hotmail.com Approved by: Dan McDonald danmcd@omniti.com Ported-by: Richard Yao richard.yao@clusterhq.com Porting notes: 1. ZoL currently does not log discards to zvols, so the portion of this patch that modifies the discard logging to mark it as freeing space has been discarded. may_delete_now had been removed from zfs_remove() in ZoL. It has been reintroduced. https://illumos.org/issues/4950
kernelOfTruth
pushed a commit
to kernelOfTruth/zfs
that referenced
this pull request
Feb 18, 2015
…esystem openzfs#2784 Reviewed by: Adam Leventhal adam.leventhal@delphix.com Reviewed by: George Wilson george.wilson@delphix.com Reviewed by: Sebastien Roy sebastien.roy@delphix.com Reviewed by: Boris Protopopov bprotopopov@hotmail.com Approved by: Dan McDonald danmcd@omniti.com Ported-by: Richard Yao richard.yao@clusterhq.com Porting notes: 1. ZoL currently does not log discards to zvols, so the portion of this patch that modifies the discard logging to mark it as freeing space has been discarded. may_delete_now had been removed from zfs_remove() in ZoL. It has been reintroduced. https://illumos.org/issues/4950
kernelOfTruth
pushed a commit
to kernelOfTruth/zfs
that referenced
this pull request
Mar 1, 2015
…esystem openzfs#2784 Reviewed by: Adam Leventhal adam.leventhal@delphix.com Reviewed by: George Wilson george.wilson@delphix.com Reviewed by: Sebastien Roy sebastien.roy@delphix.com Reviewed by: Boris Protopopov bprotopopov@hotmail.com Approved by: Dan McDonald danmcd@omniti.com Ported-by: Richard Yao richard.yao@clusterhq.com Porting notes: 1. ZoL currently does not log discards to zvols, so the portion of this patch that modifies the discard logging to mark it as freeing space has been discarded. may_delete_now had been removed from zfs_remove() in ZoL. It has been reintroduced. https://illumos.org/issues/4950
kernelOfTruth
pushed a commit
to kernelOfTruth/zfs
that referenced
this pull request
Mar 13, 2015
…esystem openzfs#2784 Reviewed by: Adam Leventhal adam.leventhal@delphix.com Reviewed by: George Wilson george.wilson@delphix.com Reviewed by: Sebastien Roy sebastien.roy@delphix.com Reviewed by: Boris Protopopov bprotopopov@hotmail.com Approved by: Dan McDonald danmcd@omniti.com Ported-by: Richard Yao richard.yao@clusterhq.com Porting notes: 1. ZoL currently does not log discards to zvols, so the portion of this patch that modifies the discard logging to mark it as freeing space has been discarded. may_delete_now had been removed from zfs_remove() in ZoL. It has been reintroduced. https://illumos.org/issues/4950
|
@ryao refreshing this patch so that we'd be back in sync with illumos would be very helpful. This addresses a real user visible issue. |
|
#3629 [buildbot, cherry-pick to master] Illumos #4950 files sometimes can't be removed from a full filesystem (#2784) so that the newer buildbots + new tree can test it. This is the updated commit I'm using, so why not use the opportunity and make an updated pull-request out of it =) The only merge conflict was updated copyright comment |
|
Closing. Replaced by #3629. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed by: Adam Leventhal adam.leventhal@delphix.com
Reviewed by: George Wilson george.wilson@delphix.com
Reviewed by: Sebastien Roy sebastien.roy@delphix.com
Reviewed by: Boris Protopopov bprotopopov@hotmail.com
Approved by: Dan McDonald danmcd@omniti.com
Ported-by: Richard Yao richard.yao@clusterhq.com
Porting notes:
modifies the discard logging to mark it as freeing space has been discarded.
reintroduced.