Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fedora 28: Fix misc bounds check compiler warnings #7830

Merged
merged 1 commit into from Aug 26, 2018
Merged

Fedora 28: Fix misc bounds check compiler warnings #7830

merged 1 commit into from Aug 26, 2018

Conversation

dioni21
Copy link
Contributor

@dioni21 dioni21 commented Aug 25, 2018

Motivation and Context

Some warnings were left on #7368

This closes issue #7826

Description

Mostly I changed occurrences of strncpy that aborted compilation.

How Has This Been Tested?

./autogen.sh && ./configure --enable-debuginfo --enable-silent-rules --enable-dependency-tracking --enable-asan --enable-debug --enable-debug-kmem && make -j 12

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@codecov
Copy link

codecov bot commented Aug 26, 2018 •
edited

Codecov Report

Merging #7830 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7830      +/-   ##
==========================================
+ Coverage    78.3%   78.31%   +0.01%     
==========================================
  Files         374      374              
  Lines      112907   112906       -1     
==========================================
+ Hits        88413    88425      +12     
+ Misses      24494    24481      -13
Flag Coverage Δ
#kernel 78.7% <100%> (-0.11%) ⬇️
#user 67.16% <66.66%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55972a6...6bfdb0a. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) Reviewed labels Aug 26, 2018
@behlendorf behlendorf merged commit 5d6ad24 into openzfs:master Aug 26, 2018
@tonyhutter tonyhutter added this to To do in 0.7.10 Aug 27, 2018
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 28, 2018
@dioni21 @tonyhutter
Fedora 28: Fix misc bounds check compiler warnings
191edfd 
Fix a bunch of truncation compiler warnings that show up
on Fedora 28 (GCC 8.0.1).

Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#7368 
Closes openzfs#7826 
Closes openzfs#7830
@tonyhutter tonyhutter moved this from To do to In progress in 0.7.10 Aug 30, 2018
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 30, 2018
@dioni21 @tonyhutter
Fedora 28: Fix misc bounds check compiler warnings
82c96da 
Fix a bunch of truncation compiler warnings that show up
on Fedora 28 (GCC 8.0.1).

Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#7368
Closes openzfs#7826
Closes openzfs#7830
@tonyhutter tonyhutter moved this from In progress to Done in 0.7.10 Aug 30, 2018
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 5, 2018
@dioni21 @tonyhutter
Fedora 28: Fix misc bounds check compiler warnings
3ea1f7f 
Fix a bunch of truncation compiler warnings that show up
on Fedora 28 (GCC 8.0.1).

Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#7368
Closes openzfs#7826
Closes openzfs#7830
@dioni21 dioni21 mentioned this pull request Oct 14, 2018
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@gmelikov gmelikov gmelikov approved these changes

@dinatale2 dinatale2 dinatale2 approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
No open projects
0.7.10
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dioni21 @behlendorf @gmelikov @dinatale2