Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark dsl_livelist_should_disable() static #9154

Merged
merged 1 commit into from Aug 14, 2019

Conversation

allanjude
Copy link
Contributor

Signed-off-by: Allan Jude allanjude@freebsd.org

Motivation and Context

This function is not used outside of dsl_dataset.c, but its lack of a prototype causes a compiler warning. Marking it static resolves this issue, and limits the scope of this function.

How Has This Been Tested?

Build tests with warnings-as-errors no longer trip on this function

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Closes #9152

This function is not used outside of dsl_dataset.c

Signed-off-by: Allan Jude <allanjude@freebsd.org>
@shartse shartse self-assigned this Aug 12, 2019
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 12, 2019
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #9154 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9154      +/-   ##
==========================================
- Coverage   79.18%   79.09%   -0.09%     
==========================================
  Files         400      400              
  Lines      121692   121692              
==========================================
- Hits        96360    96256     -104     
- Misses      25332    25436     +104
Flag Coverage Δ
#kernel 79.68% <ø> (+0.01%) ⬆️
#user 66.8% <ø> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c81f179...31bdac8. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 13, 2019
@behlendorf behlendorf merged commit d2a3291 into openzfs:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dsl_livelist_should_disable() has no prototype
4 participants