Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort list of generated files in configure.ac #9426

Merged
merged 1 commit into from Oct 9, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 8, 2019

Motivation and Context

Having the long list of Makefiles generated by ./configure in a predictable order makes it easier to work with.

Description

Alphabetize the list of Makefiles in configure.ac. I used :sort in neovim with the following locale:

devel ➜  ZoF git:(sort-configure) locale                           
LANG=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_ALL=

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

No functional change, just a quality of life improvement.

Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Oct 8, 2019
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this, it's much nicer to have them back in order.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 9, 2019
@behlendorf behlendorf merged commit 381d91d into openzfs:master Oct 9, 2019
@ghost ghost deleted the sort-configure branch October 9, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant