Put totals at the bottom, independent Y-axis, redesign horizontal charts #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arp242
changed the title
arp242
force-pushed
the
bottom-totals
branch
4 times, most recently
from
b35de26
to
ddfb665
Compare
GoatCounter has always had a "path-first" interface, rather than a "totals first" interface. I always much preferred it like that myself. The "Totals" at the top always seemed kind of misplaced to me, but I wasn't sure where/how to do it better. Placing it at the bottom under a separate header actually seems like a pretty good solution. My original thought was to display it as a half-width together with the "browsers", "systems", etc. charts (and bring back the "top refs"), but that didn't really look too good. Some people may still prefer to have the Totals at the top, the configurable dashboard discussed in #302 will enable that eventually (should be fairly soon). You can also set the pagination for the paths to e.g. 5 so it's still in view on page load. The "Top referrals" is now also back as a separate chart at the bottom; I found that actually worked better TODO: - Different scaling for "totals" and the paths.
No need to get a separate one, and move logic to get the count to a new function in case we do.
Been going back and forth on this, but it probably looks better, and adding the display numbers at the bottom of the navigation box is rather meh.
I don't know what that -3 was supposed to account for, but it seems wrong.
Just refactors the code a bit, no UI to actually configure it yet.
Didn't really care much for the underline thingy after all; it looked kinda chaotic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoatCounter has always had a "path-first" interface, rather than a
"totals first" interface. I always much preferred it like that myself.
The "Totals" at the top always seemed kind of misplaced to me, but I
wasn't sure where/how to do it better.
Placing it at the bottom under a separate header actually seems like a
pretty good solution. My original thought was to display it as a
half-width together with the "browsers", "systems", etc. charts (and
bring back the "top refs"), but that didn't really look too good.
Some people may still prefer to have the Totals at the top, the
configurable dashboard discussed in #302 will enable that eventually
(should be fairly soon). You can also set the pagination for the paths
to e.g. 5 so it's still in view on page load.
The "Top referrals" is now also back as a separate chart at the bottom;
I found that actually worked better
Fixes #291