Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something to add to the readme #10

Open
ivorpad opened this issue May 2, 2019 · 2 comments
Open

Something to add to the readme #10

ivorpad opened this issue May 2, 2019 · 2 comments

Comments

@ivorpad
Copy link

ivorpad commented May 2, 2019

  1. According to package.json the site should be started with yarn workspace site develop instead of yarn workspace starter develop
  2. If someone wants to use this Gatsby theme with their own WordPress instance, then they need to change the menu location here Menu.js#L19 to one of the locations registered by WordPress to prevent a compilation error when running yarn workspace site develop
register_nav_menus(
  array(
    'menu-1' => __( 'Primary', 'twentynineteen' ),
    'footer' => __( 'Footer Menu', 'twentynineteen' ),
    'social' => __( 'Social Links Menu', 'twentynineteen' ),
  )
);

Locations available here: MENU_1, FOOTER, SOCIAL

Great work folks! I'll keep using it and report any issues if there's any.

@boborchard
Copy link
Contributor

@ivorpad I just found the same issue when testing the theme today with the workspace name and opened a PR to fix it at #11.

@shanebp
Copy link

shanebp commented May 11, 2019

@ivorpad Thanks for listing those 2 items and the solutions. Much Appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants