-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
critical-selector inefficient with @media rules #12
Comments
Hmm, yeah. While working on #11 I think I may have found the cause of this; I'll try and roll a fix for this into that work. Thanks for the report. |
I wish I could help you with fixing this but unfortunately I won't be available for the next 2 weeks. We're about launching a project where we'd need this, so the sooner there's a fix the better. Thank you! :) |
Sounds great, @zgreen, thanks! Very much looking forward to the next release! |
Resolved by #13 |
When using
critical-selector
inside a@media
rule, the complete rule content will be seen as critical. Based on yourexample.css
:I'd expect only the
.foo
selector to be considered critical, resulting inHowever, the whole stylesheet is copied to
critical.css
.The text was updated successfully, but these errors were encountered: