Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 2 #2

Merged
merged 4 commits into from Jan 26, 2022
Merged

Milestone 2 #2

merged 4 commits into from Jan 26, 2022

Conversation

zhadier
Copy link
Owner

@zhadier zhadier commented Jan 26, 2022

The following changes were implemented in this Milestone

  • Created a new game in the Leaderboard API.
  • Implemented the "Refresh" button (receiving data from the API and parsing the JSON).
  • Implemented the form "Submit" button (sending data to the API).
  • Used async and await JavaScript features to consume the API.

Thanks for taking out the time to review this project 🧨

It really is appreciated :) ❤️

  • Note: I personally love optional suggestions so please do leave some 😄

Copy link

@BrianSammit BrianSammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APROVED 🟢 👏

Hello @zhadier,
Your project is complete! There is nothing else to say other than... Great job 👏
Congratulations! 🎉

Now you can merge this branch and move on 🥇
HAPPY CODING AND GOOD LUCK WITH THE COMMING ONES 🤞 🍀

Well-Done-Applause

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@zhadier zhadier merged commit a1fdc3b into develop Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants