Milestone 3 #3
Milestone 3 #3
Conversation
There was a problem hiding this comment.
Hi, @zhadier 馃憢
You've done a really nice job so far.
There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight 馃憦馃憦
- 鉁擠esign looks good
Required Changes 鈾伙笍
I'm leaving the comments regarding your README.md file here as it is not in your changed files. please in the future check the inline comments for required changes.
-
Please add the username and repo name to the clone link in your README setup instructions. try to keep your README looking professional this is the first thing people see when they look at your project.
-
Please use a working live link to a demo or remove it from your README if you don't want one. Currently, live link doesn't work
-
Please kindly replace the "Project" placeholder name on your README file with the actual name of your project, in this case something like "Leaderboard"
-
Also please make sure that the screenshot link you have attached is working. It's important to try and keep your README professional
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Hi @zhadier 馃憢,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 馃帀 馃帀 馃帀 馃帀 馃帀
Cheers and Happy coding!馃憦馃憦馃憦
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
The following changes were implemented in this Milestone
Thanks for taking out the time to review this project 馃Ж
It really is appreciated :) 鉂わ笍