Display homepage #24
Merged
Display homepage #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabyse1
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Status: Approved!!! 馃馃帀
Hello @zhadier 馃檵
First of all, congratulations on your amazing job!!! 馃幆
Highlights 鉁旓笍
- All features work as expected, without any conflicts when getting data from the API.
- Good job making the async functions DRY, KISS, YAGNI.
- Descriptive commit messages.
- Good pull request title and description.
I have no suggestions for now as you apply good practices properly. 馃挴
This branch is ready to merge whenever you see fit.
Happy coding during the next milestone.!!! 馃憦馃捇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes were implemented in this branch
Thanks for taking out the time to review this project 馃Ж
It really is appreciated :) 鉂わ笍