Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setViewHelper() does not return FastScrollerBuilder #5

Merged
merged 2 commits into from Nov 23, 2019
Merged

Fix setViewHelper() does not return FastScrollerBuilder #5

merged 2 commits into from Nov 23, 2019

Conversation

drakeet
Copy link
Contributor

@drakeet drakeet commented Nov 22, 2019

No description provided.

@drakeet
Copy link
Contributor Author

drakeet commented Nov 22, 2019

This looks like an obvious mistake, so I just directly sent the small PR (Sorry for no issue first). BTW, this project is great, hope it can be better and support multiple item view types in one RecycerView.

@zhanghai
Copy link
Owner

lol yes, I overlooked this when adding that method. Thanks for finding it out!

However, you will need to sign the CLA before I can merge this PR. If you don't want the trouble, I can also just go ahead and fix it myself. What do you think?

@zhanghai zhanghai self-assigned this Nov 23, 2019
@zhanghai zhanghai added the bug Something isn't working label Nov 23, 2019
@zhanghai
Copy link
Owner

If you want multipe view type support you can create your own ViewHelper, buliding upon the RecyclerViewHelper. It's kinda complex to compute all those things (esp. combined with grid support) and there are much more to be customizable (e.g. use existing view if possible? maybe ask recycler as well?) so I just didn't include it.

@drakeet
Copy link
Contributor Author

drakeet commented Nov 23, 2019

OK, I have signed it.

@drakeet
Copy link
Contributor Author

drakeet commented Nov 23, 2019

And tried the ViewHelper (so I found the problem), It's not easy to implement the multiple types support, I simply tried it, the result is not ideal, maybe I will try again.

@zhanghai zhanghai merged commit 92baf7d into zhanghai:master Nov 23, 2019
@zhanghai
Copy link
Owner

Thanks!

@zhanghai zhanghai self-requested a review November 23, 2019 08:47
@drakeet drakeet deleted the patch-1 branch November 23, 2019 08:59
@zhanghai
Copy link
Owner

zhanghai commented Nov 23, 2019 •
edited

Released in v1.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhanghai zhanghai Awaiting requested review from zhanghai

Assignees

@zhanghai zhanghai

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drakeet @zhanghai