Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using jacobians or rotation matrix for warping features #59

Open
ghost opened this issue May 4, 2022 · 0 comments
Open

Using jacobians or rotation matrix for warping features #59

ghost opened this issue May 4, 2022 · 0 comments

Comments

@ghost
Copy link

ghost commented May 4, 2022

Hi @zhanglonghao1992 ,
Thanks for sharing your implementation of the paper!

As I understand there is difference from the first to the last version of the paper regarding the using of the jacobians as part of the feature deformation- the jacobians are replaced with the rotation matrices of the source and the driving.
I see in lines 50-60 of your implementation to the dense motion model that you comment the use of the rotation matrices and now you are using the the location of the keypoints only - why did you do this?

Thanks in advance,
Tal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants