Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hw1 #29

Closed
HaoLi555 opened this issue Jul 15, 2022 · 5 comments
Closed

Hw1 #29

HaoLi555 opened this issue Jul 15, 2022 · 5 comments

Comments

@HaoLi555
Copy link

https://git.tsinghua.edu.cn/hao-li21/word-books
@zhaochenyang20
Copy link
Owner

使用了 with open 语法后不用显式地 close

@zhaochenyang20
Copy link
Owner

代码风格上，注意多加空格，代码看着太过密集

@zhaochenyang20
Copy link
Owner

缺乏文本字符串和必要的注释，def convert(char): 这个函数命名很不合适。第一，Python 没有 char 类型，第二，你这里只表达了类型，没有表达物理意义

@zhaochenyang20
Copy link
Owner

我不知道你的 argparser 能不能这么使用，也即用 while 1 来读取，直到出现正确输入。然而这么输入实际上不太合适，很少有这么用的

@zhaochenyang20
Copy link
Owner

整体完成度很棒，tqdm 的运用非常优雅！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhaochenyang20 @HaoLi555