Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strategy: discrepancies in mid profit rate calc #42

Closed
zhehaowang opened this issue Aug 10, 2019 · 1 comment
Closed

strategy: discrepancies in mid profit rate calc #42

zhehaowang opened this issue Aug 10, 2019 · 1 comment
Labels
bug Something isn't working strategy

Comments

@zhehaowang
Copy link
Owner

2596c9b introduced discrepancies in mid profit rate calc: the 30p marks in report and mid-price-percent in report have different treatment of du flat fees and shipping fees, presumably.
We should unify these.
@zhehaowang zhehaowang added strategy bug Something isn't working labels Aug 10, 2019
@zhehaowang
Copy link
Owner Author

StrategyV2 now uses its own Fees calc and this is obsolete.
That said, we should add tests for Fees calc in StrategyV2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working strategy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhehaowang