fix: redundant if ...; err != nil check

gorse-io · May 31, 2019 · d1e3dac · d1e3dac
1 parent 09dd239
commit d1e3dac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/cmd/main.go b/cmd/main.go
@@ -27,6 +27,7 @@ var versionCmd = &cobra.Command{
 	},
 }
 
+// Main is the main entry of gorse.
 func Main() {
 	rootCmd.AddCommand(commandTest)
 	rootCmd.AddCommand(commandImportFeedback)

diff --git a/engine/update.go b/engine/update.go
@@ -16,10 +16,7 @@ func UpdateItemPop(cacheSize int, dataSet core.DataSetInterface, db *DB) error {
 		recommends[i].ItemId = items[i]
 		recommends[i].Score = scores[i]
 	}
-	if err := db.SetPopular(recommends); err != nil {
-		return err
-	}
-	return nil
+	return db.SetPopular(recommends)
 }
 
 // UpdateNeighbors updates neighbors for the database.
@@ -87,8 +84,5 @@ func Update(config TomlConfig, metaData toml.MetaData, db *DB) error {
 		return err
 	}
 	// Generate popular items
-	if err = UpdateItemPop(config.Recommend.CacheSize, dataSet, db); err != nil {
-		return err
-	}
-	return nil
+	return UpdateItemPop(config.Recommend.CacheSize, dataSet, db)
 }