Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse as a datasource #184

Closed
talelk opened this issue Jul 6, 2021 · 5 comments · Fixed by #222
Closed

clickhouse as a datasource #184

talelk opened this issue Jul 6, 2021 · 5 comments · Fixed by #222
Assignees
Labels
feature/major Major feature request

Comments

@talelk
Copy link

talelk commented Jul 6, 2021

Hello,

It would be great to integrate clickhouse as a datasource for recommendation data.

@zhenghaoz zhenghaoz added the feature/major Major feature request label Jul 6, 2021
@zhenghaoz
Copy link
Collaborator

It is a good idea. Do you have any interest to implement a interface for ClickHouse? Though I could implement it, there are more important things I need to do first (new features, bugs, etc.).

@talelk
Copy link
Author

talelk commented Jul 8, 2021

will try to look at this during the weekend. nice work by the way

@zhenghaoz
Copy link
Collaborator

Good. Since ClickHouse provides SQL similar to MySQL. ClickHouse interface can be derived from MySQL implementation:

  1. Deploy a ClickHouse on local machine for unit tests.
  2. Make a copy of MySQL implementation (storage/data/sql.go) as well as tests (storage/data/sql_test.go).
  3. Rewrite SQLs for ClickHouse and make sure all tests pass.
  4. Remember to register ClickHouse storage in storage/data/database.go.

@zhenghaoz
Copy link
Collaborator

We can define DSN for ClickHouse as clickhouse://localhost:9000. ClickHouse service has been added to test environment (#188).

@gyf19
Copy link

gyf19 commented Aug 2, 2021

+1

@zhenghaoz zhenghaoz linked a pull request Aug 4, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/major Major feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants