Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mia test #7

Merged
merged 10 commits into from Mar 25, 2019
Merged

Mia test #7

merged 10 commits into from Mar 25, 2019

Conversation

2miatran
Copy link
Collaborator

MODIFIED PARTS:
Main.py

  • Modify codes to take data with split options (split is True => split to train, test, valid, split is False => keep the file and sort)
  • Add model prefix (the hospital name) and suffix (optional: user input) to output file
  • Batch_size is used in EHRdataloader => need to give batch_size parameter to dataloader instead of ut.epochs_run()
  • Results are different due to embedded => No modification. Laila's suggestion: change codes in EHRmb.py
  • Eps (currently not required for current optimizer Adagrad but might need later for other optimzers)
  • n_layer default to 1
  • args = parser.parse_args([])

Utils:

  • Remove batch_size in all functions
  • Add prefix, suffix to the epochs_run function

Note: mia_test_1 is first created for testing purpose, please ignore this file.

Proposed change to model input
Proposed changes to model input (model 2-4)
@2miatran 2miatran requested a review from lrasmy January 14, 2019 21:03
Copy link
Collaborator

@lrasmy lrasmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T-lstm to be revised

Copy link
Collaborator

@lrasmy lrasmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T-lstm to be revised

enforcements not required but no harm

further code review and slimming required

@lrasmy lrasmy self-requested a review March 25, 2019 20:12
Copy link
Collaborator

@lrasmy lrasmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now can be merged

@lrasmy lrasmy closed this Mar 25, 2019
@lrasmy
Copy link
Collaborator

lrasmy commented Mar 25, 2019

Done

@lrasmy lrasmy reopened this Mar 25, 2019
@lrasmy lrasmy merged commit 6cb003a into master Mar 25, 2019
@lrasmy lrasmy deleted the mia_test branch June 24, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants