Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It might be safer to add a timeout in concurrent api call #1

Closed
ltebean opened this issue Jan 16, 2015 · 1 comment
Closed

It might be safer to add a timeout in concurrent api call #1

ltebean opened this issue Jan 16, 2015 · 1 comment

Comments

@ltebean
Copy link

ltebean commented Jan 16, 2015

  1. pipeRenderResultQueue
    If any of the threads fails to put a result in it, the pipeRenderResultQueue.take() in ControllerInterceptor would wait forever.
  2. barrierLatch
    Similarly, barrierLatch.await() will wait forever if any thread fails to execute latch.countdown().

Since if the thread executing the try-catch code is interrupted or killed, the finally block will not execute

@zhongliangjun1
Copy link
Owner

Thanks for the reminding.

In plumber-1.1.1-SNAPSHOT a response.timeout configuration has been added to resolve the potentially problems which you mentioned above.

You would be able to see the code adjustment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants