Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about scaling data. #41

Closed
lk1983823 opened this issue Mar 1, 2021 · 3 comments
Closed

A question about scaling data. #41

lk1983823 opened this issue Mar 1, 2021 · 3 comments

Comments

@lk1983823
Copy link

lk1983823 commented Mar 1, 2021

In your model code, I find you used data scaler for train\val\test dataset separately. However, I think you probably use future information during validating and testing process. Because, during the online prediction, we can't get the whole data in advance. In addition, I didn't find inverse transformation, which is important to show the real model performance for testing dataset. Can you give more information as to how to deal with data scaling and inverse transformation? Thanks.

@cookieminions
Copy link
Collaborator

Thank you very much for your reminder, train data should be used to calculate mean and std when scaling data, while validation data and test data should only be scaled.

We will fix the above problems and the inverse_transform problem immediately.

Thanks!

@lk1983823
Copy link
Author

Thank you very much for your reminder, train data should be used to calculate mean and std when scaling data, while validation data and test data should only be scaled.

We will fix the above problems and the inverse_transform problem immediately.

Thanks!

Thanks, could you remind me an update if it is done?

@cookieminions
Copy link
Collaborator

Thanks for your attention! We have updated the code about data scaling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants