Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNMF-E errors on movies with NaNs #31

Closed
bahanonu opened this issue Oct 23, 2018 · 2 comments
Closed

CNMF-E errors on movies with NaNs #31

bahanonu opened this issue Oct 23, 2018 · 2 comments

Comments

@bahanonu
Copy link

@zhoupc

The current codebase throws an error at
https://github.com/zhoupc/CNMF_E/blob/master/ca_source_extraction/endoscope/connectivity_constraint.m#L13
if the movie contains NaNs (as might be the case after motion correction when the borders are cropped with NaNs). Re-ran a couple of movies after setting the NaNs to zero and it ran fine without errors.

Is there a way to have CNMF-E automatically account for this when running movies (e.g. have a inputMovie(isnan(inputMovie)) = 0; % or mean pixel value) so we don't have to alter or duplicate existing datasets? e.g. updating `Sources2D.load_data' method? https://github.com/zhoupc/CNMF_E/blob/master/ca_source_extraction/%40Sources2D/Sources2D.m#L1073

@zhoupc
Copy link
Owner

zhoupc commented Oct 23, 2018

good point. I added a line 211 in https://github.com/zhoupc/CNMF_E/blob/master/ca_source_extraction/%40Sources2D/Sources2D.m

@zhoupc zhoupc closed this as completed Oct 23, 2018
@bahanonu
Copy link
Author

@zhoupc

Error still occurs on HDF5 movies with NaNs. Is there anywhere else in the code that the movie is called that would lead to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants