Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in demo 1p large data, update spatial parallel - zero sparse A column #38

Closed
youngju0565 opened this issue Jul 23, 2019 · 3 comments

Comments

@youngju0565
Copy link

Hello,

I'm a graduate student in Prof. Minwhan Jung's lab, KAIST, South Korea.
I have an issue that appears when running demo_large_data_1p.m, in the first update of spatial components, after
[center_res, Cn_res, PNR_res] =neuron.initComponents_residual_parallel([], save_initialization, use_parallel, min_corr_res, min_pnr_res, seed_method_res);.

The error message leads me to line 66,
IND = sparse(logical(determine_search_location(obj.A, search_method, options)));
and again to line 66 of determine_search_location, which is a parfor.
I run manually this parfor and found that in line 69, [V,D] = eig(Vr{i}); was stopping me, as a column of obj.A was a zero sparse. I realized that some zero-pixel neurons were existing, but the fixing of this false positives (remove_false_positives) is placed after this spatial update in the demo, so I'm opening this issue.

I tried to overcome with starting with higher min_pnr and min_corr but did not work.

Thanks.
Young Ju.

@youngju0565
Copy link
Author

To be specific, (as my Matlab is in Korean) let me describe the error exactly.
It says, "the input matrix should not contain NaN or infinite numbers", which eig(Vr{i}) makes.
Thanks.

@zhoupc
Copy link
Owner

zhoupc commented Jul 24, 2019

I fixed the bug by handling this abnormal case. @in0565, can you test the new code and let me know how it works. Thanks.

@youngju0565
Copy link
Author

@zhoupc Now it works with no errors. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants