Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

division of the loss value by eta #5

Open
DenisKoposov opened this issue Dec 23, 2021 · 1 comment
Open

division of the loss value by eta #5

DenisKoposov opened this issue Dec 23, 2021 · 1 comment

Comments

@DenisKoposov
Copy link

DenisKoposov commented Dec 23, 2021

Hello! Thank you for a great paper. Could you please explain the idea behind the division of the loss value by eta? I didn't see any information related to this in the paper. In my experiments, I haven't observed any significant difference between the code with/without this division, but maybe I am missing something important.

obj_loss = updated_loss / eta

@zhuchen03
Copy link
Owner

Hello, thanks for the interest! Indeed, this part is not thoroughly discussed in the paper. Originally we tried minimizing $L(\theta-\eta * g) - L(\theta) \approx - \eta ||g||^2 $, so dividing by $\eta$ makes the objective less sensitive to the choice of the target learning rate $\eta$. However, this objective can be unstable, since it does not require the initial loss or the updated loss to be small. Later we switched to the current version without removing the "dividing by eta" part for controlled experiments, and we haven't thoroughly analyzed whether it is more desirable to keep this term. It should have similar effects in keeping the objective less sensitive to the choice of the target learning rate $\eta$, e.g., when $\eta$ is very small, the updated loss can be very close to the initial loss, and vice versa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants