Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that the new setParentServices()'s lookupFromScope(..., EXPLICIT) behavior is what is expected #277

Open
Zhuinden opened this issue Jul 3, 2023 · 0 comments

Comments

@Zhuinden
Copy link
Owner

Zhuinden commented Jul 3, 2023

Currently, all service lookup done to the parent services (added in 9019cea ) is done with ALL, even if you passed EXPLICIT.

On one hand, passing EXPLICIT up would make sense, as that's what you received.

On the other hand, knowing that you can't pass up ALL would mean your child stack knows a bit too much about what scopes are available in the parent, whom you should be treating as a black box.

I can technically argue for both sides, so I made it unified and it just does a "lookup from provided scope", where the default has always been ALL.

@Zhuinden Zhuinden changed the title Veriy that the new setParentServices()'s lookupFromScope(..., EXPLICIT) behavior is what is expected Verify that the new setParentServices()'s lookupFromScope(..., EXPLICIT) behavior is what is expected Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant