NumUsed is not defined

[aviankona]

Hi,

I saw your project and was very impressed.

While testing to see it's performance, I've came across an error.

"NumUsed is not defined" on lame.all.js line 15163.

Would appreciate a bug fix in order to complete the cycle.

Thanks,
Avi.

[zhuker]

fixed
let me know if it works for you.

[aviankona]

thanks for the fix,

now it throws "fill_buffer_resample is not defined"

lame.all.js:15169 Uncaught ReferenceError: fill_buffer_resample is not defined

[zhuker]

can you send me the code which reproduces the bug?
do you intentionally resample?

[aviankona]

Hi Alex,

Here is my complete flow:

• record audio with the WebAudio Api,
  block size 2048
  sample rate - according to the mic input (will probably be 44,100 or 48,000).
• Convert it to WAV - preserving it's sample rate, using it's block size. defining the WAV output to mono. the function returns an UInt16Array.
• Execute a copy of your function (from the example page) with the original sample rate and block size.

I'm executing the conversion in a web worker.

See conversion function below:
function _newEncodeMp3( uint16Array ){
var liblame = new lamejs();
var mp3enc = new liblame.Mp3Encoder(1, ORIGINAL_SAMPLE_RATE, 16);
var remaining = uint16Array.length;
var maxSamples = ORIGINAL_BLOCK_SIZE;
for (var i = 0; remaining >= maxSamples; i += maxSamples) {
var mono = uint16Array.subarray(i, i + maxSamples);
var mp3buf = mp3enc.encodeBuffer(mono);
if (mp3buf.length > 0) {
//TODO write to output
}
remaining -= maxSamples;
}
var mp3buf = mp3enc.flush();

    return mp3buf;
}

Thanks for the support,
Avi.

[zhuker]

what was the ORIGINAL_SAMPLE_RATE when the code failed?

[zhuker]

are you sure you want 16kbps mp3?
for such low bitrates lame does resampling to a lower sample rate

[aviankona]

My sample rate is 44100
what's the minimum kbps that you suggest?

[zhuker]

depends on your application
try 64 and let me know if it works for you

[zhuker]

just fixed the resampling code
should work with 16kbps now
try it

[aviankona]

Just tested it.

it fails on the initialization with the following error:
lame.all.js:15509 Uncaught ReferenceError: fs is not defined

[zhuker]

my bad, forgot to disable tests, just fixed

[aviankona]

Hi Alex,

Conversion function has finished successfully!

I'll create an output file and check the conversion.

Thanks!
Avi.