Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mp3's LAME Version Code is wrong #67

Open
xiangyuecn opened this issue Nov 1, 2019 · 0 comments
Open

Mp3's LAME Version Code is wrong #67

xiangyuecn opened this issue Nov 1, 2019 · 0 comments

Comments

@xiangyuecn
Copy link

Problem

The LAME information of the encoded MP3 file is garbled.

Bad data (MP3 HEX):

//LAME????????
4C 41 4D 45 03 00 09 08 00 04

Data that should have appeared:

//LAME3.98.4
4C 41 4D 45 33 2E 39 38 2E 34

How to solve

All charAt should be replaced with charCodeAt, because character selection Java and JS are different.

Major impact codes:

lamejs/src/js/BitStream.js

Line 201 in 0ae7a4a

putbits2(gfc, version.charAt(i), 8);

charCodeAt should be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xiangyuecn