Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullability specifier to all pointers in ZLPeoplePickerViewController.h #7

Open
king7532 opened this issue May 7, 2015 · 4 comments

Comments

@king7532
Copy link
Collaborator

king7532 commented May 7, 2015

This will help when using this project in a Swift app :)

Ideally all the header files should be updated to include nullability specifiers for all pointers to eliminate the compiler warnings [-Wnullability-completeness].

Here's a great blog article on it:
https://developer.apple.com/swift/blog/?id=25

@zhxnlai
Copy link
Owner

zhxnlai commented May 7, 2015

Thanks for pointing this out! Let me add you as a collaborator.

@king7532
Copy link
Collaborator Author

king7532 commented May 7, 2015

Thank you!

@king7532
Copy link
Collaborator Author

king7532 commented May 7, 2015

I was hoping that since you have more knowledge of the codebase that you could add the nullability specifiers for the ZLPeoplePickerViewController.h now and then I'll start adding them as I get more familiar this project. I'm hoping to ship my app with this project in the next few weeks. Thanks again!

@zhxnlai
Copy link
Owner

zhxnlai commented May 9, 2015

Sorry for the late reply! I am really excited that you found this project useful but it has been six months since I last worked on it. I will do my best to help making it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants