Reactor recursion doesn't work

[Simcon]

The following test case for recursion doesn't appear to work (ko 2.2.1, ko.mapping 2.4.0):

var data = "{\"id\":1,\"items\":[{\"id\":1},{\"id\":2}]}";

var model = ko.mapping.fromJSON(data);

ko.watch(model, { recurse: true }, function () {
    alert('Reactor');
});

// Change the data
model.id(2); // Reacts OK
model.items()[0].id(2); // Does not react

[ZiadJ]

Thanks for the suggestion.

I quickly modified the code to get it to work in your case. To test it you need to replace lines 62 to 72 with this:

function watchChildren(object, recurse) {
    if (recurse && (recurse === true || recurse >= 0)) {
        if (typeof object === 'object') {
            watchObjectOrArray(object, recurse === true || Number(recurse) - 1);
        } else if (ko.isSubscribable(object)) {
            if (object() instanceof Array)
                watchObjectOrArray(object(), recurse === true || Number(recurse) - 1);
        }
    } else if (ko.isSubscribable(object)) {
        context.watch(object, options, valueEvaluatorFunction);
    }
}

function watchObjectOrArray(object, recurse) {
    // Listen to all subscribables within specified object or array.
    if (typeof object === 'object') {
        for (var property in object)
            watchChildren(target[property], recurse);
    } else if(object instanceof Array) {
        for (var i = 0; i < object.length; i++)
            watchChildren(object[i], recurse);
    }
}

options.targetParent = target;

watchObjectOrArray(target, options.recurse);

Please let me know your thoughts about it and I'll update the source once it passes your tests.

[grennis]

I don't think this works correctly when items are added or removed from the child array.

[ZiadJ]

I've put up a beta version of the code that supports it here:
https://github.com/ZiadJ/knockoutjs-reactor/blob/master/knockout.reactor.latest.js

Sorry I haven't had much time to test it yet but feel free to let me know if you come across any bugs.

[ZiadJ]

It's been a while since I've last been around and I've finally fixed the issue. I've tested it against large and complex object graphs generated by BreezeJS. So everything should work fine now as long as the depth value allows it to reach your nested elements.

P.S recurse has been replaced by depth in the latest version.