Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: simplify CLI usage #63

Merged
merged 2 commits into from Nov 29, 2023
Merged

feat!: simplify CLI usage #63

merged 2 commits into from Nov 29, 2023

Conversation

Zidious
Copy link
Owner

@Zidious Zidious commented Nov 29, 2023

I've been wanting to do this refactor for a while , what's changed?

  • Simplified the CLI usage from crypto --price bitcoin to crypto bitcoin
  • Consolidated internal code to make it easier to understand and develop future features

Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -7,7 +7,8 @@ import { fileURLToPath } from 'url'
const __filename = fileURLToPath(import.meta.url)
const CLI = path.resolve(path.dirname(__filename), '..', 'dist', 'index.js')

describe('crypto-cli', () => {
// TODO: Skipping tests, we're getting rate limited: https://github.com/Zidious/crypto-cli/issues/17
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we should fix sooner rather than later

@Zidious Zidious merged commit 6a61b55 into develop Nov 29, 2023
3 checks passed
@Zidious Zidious deleted the feat-breaking-refactor branch November 29, 2023 04:16
@Zidious Zidious mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant