Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compact mode layout broke with 120 minutes max timer config #393

Merged
merged 3 commits into from
Jun 15, 2023
Merged

fix: compact mode layout broke with 120 minutes max timer config #393

merged 3 commits into from
Jun 15, 2023

Conversation

ziadevcom
Copy link
Contributor

@ziadevcom ziadevcom commented Jun 13, 2023

I have fixed broken layout bug which appeared after we added 120 minutes max config. I did minimum modifications to fix this. @roldanjr

This PR fixes #389

Tested on windows, installer and portable version.

Here are some comparisons, broken vs fixed screenshots.

image
image

Copy link
Member

@roldanjr roldanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roldanjr roldanjr changed the title 389 - Fix compact mode layout broke with 120 minutes max timer config fix: compact mode layout broke with 120 minutes max timer config Jun 15, 2023
@roldanjr roldanjr merged commit c8c3c66 into zidoro:master Jun 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Done
Development

Successfully merging this pull request may close these issues.

Bug Report: Compact mode layout broke with 120 minutes max timer config
2 participants