New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remove edit #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGES REQUIRED 🔴 🛑
Hello @zieeco, great job you are doing so far in this project. 💯
TO HIGHLIGHT:
- Your project is professional
- Your repo is professional
- Well structured files
- Great job with the add, update and delete actions.
However, there are a few changes to make to move to the next project 🛠️ . Keep working hard 💪 💻
Required Changes ♻️
- You are missing the property index in the tasks. kindly add this property as one of the project requirements.
Remember that the index value must be the length of the array.
Please make these required changes and send it again for another review 👍 💪
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
HAPPY CODING!!! 😄
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
STATUS: APPROVED ✔️Hi @zieeco , Index property is setup properly and is being updated every time an idem is deleted! Good Job! 🎉💯🌟 Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀 As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form. |
To Do List: Add_remove
In this milestone, I did the following
status update
file in thesrc
foldernpm run build
command to generate the files in thedist folder
style.css
fileindex
parameter to thesaveToDos()
in theindex.js
file according to the required changes from the previous code review..