Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal issue checking for the use of javaScript, HTML and CSS best practices #8

Open
zieeco opened this issue Jan 17, 2022 · 0 comments

Comments

@zieeco
Copy link
Owner

zieeco commented Jan 17, 2022

Hi @zieeco 馃憢馃徎,

You've done a great job so far by implementing all the features of your app, However:
There are some issues that you still need to work on according to following the JavaScript, HTML, and CSS best practices!
Please refer to the links below:

  • Please reduce the addition of unnecessary trailing spaces where you declared your variables, I think it would be better if you added the trailing space after all your variables declaration, therefore making them next to each other here and also to these lines where you added the eventListeners in your index.js file.
  • According to the YAGNI rule, comparing this line of code with this line of code, the latter: label variable and its CSS property label.style.textDecoration: 'line-through' was never having any effect in your code, so why add it when you won't use it. Please remove it as it does nothing in your application!
  • Also, the variable itemm is not descriptive enough. Please name your variables in a way that reveals the intention behind them in your statusUpdate.js file.

Cheers and happy coding! 馃捇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant