Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement peer discovery #1

Closed
2 of 3 tasks
keyvank opened this issue Feb 8, 2022 · 5 comments
Closed
2 of 3 tasks

Implement peer discovery #1

keyvank opened this issue Feb 8, 2022 · 5 comments

Comments

@keyvank
Copy link
Member

keyvank commented Feb 8, 2022

  • There should be a list of bootstrap nodes somewhere. Maybe put them on a GitHub repo.
  • Nodes should be able to get initial nodes from bootstrap node list and discover the whole network. Nodes do this by introducing themselves through http POST requests to other nodes and discovering their peers through GET requests. This happens in a fixed interval.
  • Nodes can filter the messages they want to receive from their peers through Bloom Filters. They submit their Bloom Filter in the introduction phase.
@n1rna
Copy link
Contributor

n1rna commented May 12, 2022

would like to work on this one if it's not taken

@n1rna
Copy link
Contributor

n1rna commented May 19, 2022

For the list of bootstrap nodes, you can check how Bitcoin does it: https://github.com/bitcoin/bitcoin/tree/master/contrib/seeds

It makes sense to not to hardcode a repository's url inside the code because the repo might be hosted on different places. the list of seed nodes can indeed be kept on a repo or any hosted page, but the list should be compiled into the node and the node should not need to fetch them from the public internet.

what do you think? I can work on that.

@keyvank
Copy link
Member Author

keyvank commented May 20, 2022

Well done!

@n1rna
Copy link
Contributor

n1rna commented May 21, 2022

As we discussed, we may not need the bloom filters for now. If they happen to come up later we can discuss the details on them again. but for now, we may close the issue :)

@keyvank
Copy link
Member Author

keyvank commented May 22, 2022

@n1rna Agreed

@keyvank keyvank closed this as completed May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants