Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.10 support through github actions #17

Closed
dwsmith1983 opened this issue Oct 4, 2021 · 9 comments · Fixed by #18
Closed

python 3.10 support through github actions #17

dwsmith1983 opened this issue Oct 4, 2021 · 9 comments · Fixed by #18
Assignees
Labels
enhancement New feature or request

Comments

@dwsmith1983
Copy link
Collaborator

@zifeo looks like the python on github ci isn't updated for python 3.10 release. I just pushed a dev branch to test if everything would work but issues with python 3.10 being looked up as 3.1

@dwsmith1983 dwsmith1983 added the enhancement New feature or request label Oct 4, 2021
@zifeo
Copy link
Owner

zifeo commented Oct 5, 2021

@dwsmith1983 try adding quotes "3.10", also you seems to have push a renamed git directory .git2?

@dwsmith1983
Copy link
Collaborator Author

@zifeo this git 2 directory is strange. I am not sure where it came from, but I deleted so not sure why it went there. I saw it come up on git add. and the git rm -r --cached .git2 plus I deleted. It just refuses to die.

@dwsmith1983
Copy link
Collaborator Author

@zifeo looks like we have to wait 2-3 weeks
actions/setup-python#249

@zifeo
Copy link
Owner

zifeo commented Oct 5, 2021

@dwsmith1983 actions/setup-python#249 (comment) seems to say it is already working? What's the missing piece?

@dwsmith1983
Copy link
Collaborator Author

@zifeo Makshim (I think the spelling) said it isn't pre-installed on the image yet. I think when the close the ticket it will be ready.

@dwsmith1983
Copy link
Collaborator Author

dwsmith1983 commented Oct 6, 2021

@zifeo working now but we have

Run poetry run pytest -s tests
============================= test session starts ==============================
platform linux -- Python 3.10.0, pytest-3.10.1, py-1.10.0, pluggy-0.13.1
rootdir: /home/runner/work/dataconf/dataconf, inifile:
collected 0 items / 1 errors

==================================== ERRORS ====================================
____________________ ERROR collecting tests/test_parser.py _____________________
<frozen importlib._bootstrap>:939: in _find_spec
    ???
E   AttributeError: 'AssertionRewritingHook' object has no attribute 'find_spec'

During handling of the above exception, another exception occurred:
../../../.cache/pypoetry/virtualenvs/dataconf-eoI6Aqc9-py3.10/lib/python3.10/site-packages/py/_path/local.py:704: in pyimport
    __import__(modname)
<frozen importlib._bootstrap>:1027: in _find_and_load
    ???
<frozen importlib._bootstrap>:1002: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:941: in _find_spec
    ???
<frozen importlib._bootstrap>:915: in _find_spec_legacy
    ???
../../../.cache/pypoetry/virtualenvs/dataconf-eoI6Aqc9-py3.10/lib/python3.10/site-packages/_pytest/assertion/rewrite.py:162: in find_module
    source_stat, co = _rewrite_test(self.config, fn_pypath)
../../../.cache/pypoetry/virtualenvs/dataconf-eoI6Aqc9-py3.10/lib/python3.10/site-packages/_pytest/assertion/rewrite.py:412: in _rewrite_test
    co = compile(tree, fn.strpath, "exec", dont_inherit=True)
E   TypeError: required field "lineno" missing from alias
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 0.14 seconds ============================
Error: Process completed with exit code 2.

Maybe the pytest version needs to be changed. I see some issues with this back in 2020 and it looks a version issue. Maybe update to 6.2.5?

@zifeo
Copy link
Owner

zifeo commented Oct 6, 2021

@dwsmith1983 this is indeed a python 3.10 issue, poetry update pytest@latest should do the job.

@dwsmith1983
Copy link
Collaborator Author

@zifeo for adding 3.10 support, version to 0.2.0?

@zifeo
Copy link
Owner

zifeo commented Oct 7, 2021

@dwsmith1983 yes, definitely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants