Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revoke model] Revoke command is successfully executed for invalid pair of vid and pid parameters. #12

Closed
julia-aksyanova opened this issue Sep 3, 2020 · 2 comments
Assignees
Projects

Comments

@julia-aksyanova
Copy link
Collaborator

julia-aksyanova commented Sep 3, 2020

Severity:
major

Build info:
0505970

Steps to reproduce:

  1. Add to the system model-info with valid vid and pid (zblcli tx modelinfo add-model...).
  2. Add test-result for this model: use the same vid and pid parameters (zblcli tx compliancetest add-test-result...).
  3. Certify this model: use the same vid and pid parameters (zblcli tx compliance certify-model...).
  4. Revoke the model (zblcli tx compliance revoke-model...) but:
  • make a typo in vid and\or pid parameters;
  • or enter any not-existing vid and\or pid parameters.
  1. Look at the results of the revoke command execution.

Actual results:
The revoke command is successfully executed.

Expected results:
The error should appear if the revoke command contains not-existing vid and pid parameters: "No model info associated with the vid= and pid= on the ledger.".

Additional info:
If the user makes revocation with invalid pair of vid and pid parameters and then he\she decides to certify the same invalid pair of vid and pid, the certification is successfully executed.
But if check the info about mpdel (zblcli query modelinfo model --vid=<value> --pid=<value>), there is no info about this model.
revocation-and-certification-invalid-vid-and-pid

image

@julia-aksyanova
Copy link
Collaborator Author

Additional info:
If you look at the https://gitlab.dsr-corporation.com/zb-ledger/zb-ledger/-/blob/master/docs/use_cases/use_cases_device_off_ledger_certification.png, it is possible to execute the revoke-model command without previous certification. But it is important that the system contains model-info with vid and pid pararmeters which are used in the revoke-model command.

@ashcherbakov ashcherbakov added this to the v0.3 milestone Sep 10, 2020
@ashcherbakov ashcherbakov added this to Backlog in DCL Sep 10, 2020
@ashcherbakov ashcherbakov moved this from Backlog to To do in DCL Oct 22, 2020
@ashcherbakov ashcherbakov moved this from To do to In progress in DCL Oct 29, 2020
@ashcherbakov
Copy link
Contributor

Fixed in #73

@ashcherbakov ashcherbakov moved this from In progress to Done in DCL Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
DCL
  
Done
Development

No branches or pull requests

3 participants