Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Certify model] Need to remove the possibility to certify model several times from different accounts. #13

Closed
julia-aksyanova opened this issue Sep 3, 2020 · 1 comment
Assignees
Projects

Comments

@julia-aksyanova
Copy link
Collaborator

Severity:
major

Build info:
0505970

Precondition:
The system should have two or more users with the ZBCertificationCenter role.

Steps to reproduce:

  1. Add to the system model-info with valid vid and pid (zblcli tx modelinfo add-model...).
  2. Add test-result for this model: use the same vid and pid parameters (zblcli tx compliancetest add-test-result...).
  3. Certify this model using one account with the ZBCertificationCenter role: use the same vid and pid parameters (zblcli tx compliance certify-model...).
  4. Try to certify the same pair of vid and pid:
    a) using the same account with the ZBCertificationCenter role (from step 3);
    b) using another account with the ZBCertificationCenter role (not the same as in step 3).
  5. Look at the result of the command execution.

Actual results:
The second certification command for the same pair of the vid and pid is successfully executed.

Expected results:
a) When the same account with the ZBCertificationCenter role (from step 3) is used at the second request, the confirmation message should appear: "override the existing certification info [y/N]: " (message should be discussed).
b) When another account with the ZBCertificationCenter role (not the same as in step 3) is used at the second request, error message should appear info the results: "Model with vid= and pid= is already certified on the ledger."(message should be discussed).

@ashcherbakov ashcherbakov added this to the v0.3 milestone Sep 10, 2020
@ashcherbakov ashcherbakov added this to Backlog in DCL Sep 10, 2020
@ashcherbakov ashcherbakov moved this from Backlog to To do in DCL Oct 22, 2020
@ashcherbakov ashcherbakov moved this from To do to In progress in DCL Oct 29, 2020
@ashcherbakov
Copy link
Contributor

Fixed in #70

@ashcherbakov ashcherbakov moved this from In progress to Done in DCL Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
DCL
  
Done
Development

No branches or pull requests

3 participants