Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defect: Approvals were getting overwritten in store #338

Closed
ashcherbakov opened this issue Apr 21, 2022 · 1 comment
Closed

Defect: Approvals were getting overwritten in store #338

ashcherbakov opened this issue Apr 21, 2022 · 1 comment
Labels
bug Something isn't working
Projects
DCL
Milestone
v1.0: Main Net La...

Comments

@ashcherbakov
Copy link
Contributor

When a new account is approved, the approvals field is empty.
@ashcherbakov ashcherbakov added this to Backlog in DCL via automation Apr 21, 2022
@ashcherbakov ashcherbakov added this to the v1.0: Main Net Launch milestone Apr 21, 2022
@ashcherbakov ashcherbakov added the bug Something isn't working label Apr 21, 2022
@ashcherbakov
Copy link
Contributor Author

Fixed in #258, then reverted as it turned out to be a breaking change, and re-applied back in #315 for 0.10.0 release.

The reason of the issue is that SetAccount is called by Cosmos SDK during signature verification. Due to an issue in DCL code, approvals got overwritten.

DCL automation moved this from Backlog to Done Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
DCL
  
Done
Milestone
v1.0: Main Net Launch
Development

No branches or pull requests
1 participant
@ashcherbakov