Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion of Model Versions #421

Closed
ashcherbakov opened this issue Nov 11, 2022 · 1 comment
Closed

Deletion of Model Versions #421

ashcherbakov opened this issue Nov 11, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request size: M
Projects

Comments

@ashcherbakov
Copy link
Contributor

ashcherbakov commented Nov 11, 2022

There is a command to delete a model, but there is no command to delete a model version.

  1. Model version can be deleted by the owner Vendor (account with the VID created the model) only before it is certified and certification is issued by CSA.
  2. When a Model is deleted, the corresponding model versions must be deleted as well
  3. Model can be deleted by the owner Vendor (account with the VID created the model) only before at least one of its Model Versions is certified and certification is issued by CSA.
    • Example: (A)/(B)/1.0, (A)/(B)/2.0, (A)/(B)/3.0 (Certified). In this scenario, ModelVersion (A)/(B)/(1.0 - 2.0) can be deleted. However, model (A)/(B) can not be deleted because of the certification record on (A)/(B)/3.0

Notes:

  • The deletion must be a soft-delete final delete (completely remove from the State the same way as a Model)
  • GET_DELETED_MODEL_VERSION(s) needs to be implemented
  • Separate PRs cane be sent for each item (1, 2, 3)
  • The model/modelversion can not be deleted, if its certification status is revoked or provisioned. In other words, deletion can not happen if there is any certification status.
@ashcherbakov ashcherbakov added this to Backlog in DCL via automation Nov 11, 2022
@ashcherbakov ashcherbakov added enhancement New feature or request size: M labels Nov 11, 2022
@ashcherbakov ashcherbakov moved this from Backlog to To do in DCL Feb 14, 2023
@DenisRybas DenisRybas moved this from To do to In progress in DCL Feb 22, 2023
@DenisRybas DenisRybas self-assigned this Feb 22, 2023
@lazizcodesatdsr
Copy link
Collaborator

lazizcodesatdsr commented Mar 14, 2023

FYI, @DenisRybas has initialized the deletion skeleton (https://github.com/zigbee-alliance/distributed-compliance-ledger/tree/delete-model-version)
While he is busy with another task, I will take the implementation for the point 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size: M
Projects
No open projects
DCL
  
Done
Development

No branches or pull requests

3 participants