Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Model requires "partNumber" and "productLabel" but those attributes should be optional #429

Closed
jcps07 opened this issue Jan 17, 2023 · 0 comments
Assignees
Projects

Comments

@jcps07
Copy link
Contributor

jcps07 commented Jan 17, 2023

Adding a Model in DCL requires fields "partNumber" and "productLabel" but those attributes are Optional in the Basic Information Cluster (Table 11.1.6.3 Attributes from Matter Spec).
Enforcing them in the DCL is not correct.

~$ dcld tx model add-model --vid=0x3000 --pid 1234 --deviceTypeID 1 --productName "ProdName" --from "test-vendor"
Error: required flag(s) "partNumber", "productLabel" not set

image

@ashcherbakov ashcherbakov added this to Backlog in DCL via automation Feb 14, 2023
@ashcherbakov ashcherbakov moved this from Backlog to To do in DCL Feb 14, 2023
@lazizcodesatdsr lazizcodesatdsr self-assigned this Feb 20, 2023
@lazizcodesatdsr lazizcodesatdsr moved this from To do to In progress in DCL Feb 20, 2023
@ashcherbakov ashcherbakov moved this from In progress to In Review in DCL Mar 1, 2023
@ashcherbakov ashcherbakov moved this from In Review to Done in DCL Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
DCL
  
Done
Development

No branches or pull requests

3 participants