Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I need to be able to get the information about the created account even if the account is revoked #54

Closed
ashcherbakov opened this issue Sep 28, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request size: L
Projects

Comments

@ashcherbakov
Copy link
Contributor

ashcherbakov commented Sep 28, 2020

Currently revoked accounts are removed from the state. But all the entities created by this account are considered as valid, but with unknown owner/creator.
As a user, I need to be able to get the information about the creator account even if the account is revoked.

Options:

  • O1: Add a new entity RevokedAccount. Create a new Revoked Account when deleting an Account. Support queries for RevokedAccount(s).
  • O2: Add a revoked flag for the current Account entity. Toggle the flag on revocation instead of removing the account.

Notes

  1. We need to make sure that it's not possible to send a transaction signed by a revoked account.
  2. We need to support re-adding of a revoked account (via a usual propose/approve account requests). So, the chosen option must support it.
@ashcherbakov ashcherbakov added this to the v0.4 milestone Sep 28, 2020
@ashcherbakov ashcherbakov removed this from the v0.4 milestone Nov 1, 2021
@ashcherbakov ashcherbakov added this to Backlog in DCL via automation Feb 11, 2022
@ashcherbakov ashcherbakov added enhancement New feature or request size: M labels Feb 11, 2022
@ashcherbakov ashcherbakov added this to the v0.7: Main Net Launch milestone Feb 11, 2022
@ashcherbakov ashcherbakov moved this from Backlog to To do in DCL Feb 11, 2022
@uabjabborov uabjabborov moved this from To do to In progress in DCL Mar 9, 2022
@abdulla-ashurov
Copy link
Collaborator

Plan regarding Note 1:

  1. Add a new entity for saving Revoked Account
  2. When revoking an account, if we get enough votes for deletion, then that account will be saved in map Revoked Account, then we revoked that account.
  3. Add query for getting specific revoked accounts and all revoked accounts.

@abdulla-ashurov
Copy link
Collaborator

abdulla-ashurov commented Mar 15, 2022

Plan regarding Note 2:

  1. Use for re-adding of revoked account existing API:
    1. propose-add-account
    2. approve-add-account
  2. When we have enough votes for approve-add-account we should revoke that account from entity RevokedAccount(map)

@ashcherbakov ashcherbakov changed the title As a user, I need to be able to get the information about the creator account even if the account is revoked As a user, I need to be able to get the information about the created account even if the account is revoked Mar 15, 2022
@ashcherbakov ashcherbakov moved this from In progress to To do in DCL Mar 17, 2022
@hawk248
Copy link
Collaborator

hawk248 commented Mar 17, 2022

Post Mainnet 1.0

@uabjabborov uabjabborov moved this from To do to In progress in DCL Mar 21, 2022
@uabjabborov uabjabborov moved this from In progress to In Review in DCL Mar 22, 2022
DCL automation moved this from In Review to Done Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size: L
Projects
No open projects
DCL
  
Done
Development

No branches or pull requests

3 participants