macho: move load command wrappers and parsing utils to std.macho #10310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helper functions such as `commands.sectionName`, etc. should really belong in `std.macho.section_64` extern struct.
This way we will finally be able to share common parsing logic between different Zig components and 3rd party packages.
kubkon
force-pushed
the
macho-common-functions
branch
from
5e42306
to
828f61e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link.MachO.commands.sectionNametostd.macho.section_64.sectName, etc.LoadCommand, etc., and parsing utils tostd.macholink.MachO.commandsmodule as it's now obseletestd.macho.LoadCommandunionThis is the first step in trying to unify MachO parsing utilities between the linker and stack trace printing. However, since the former currently doesn't take advantage of mmap while the latter does, they cannot yet be simplified, but as this should provide a common platform for such changes. I also intend to reuse the MachO parsing utils in the upcoming
zig ldtest harness that I'm currently working on.